Change module feature default to capitalize #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK once you make the tests green :-) |
|
Also, I think the commit message should say "and now foreman_proxy::module does too" ;) |
foreman_proxy::plugin::module uses $title.capitalize() and now foreman_proxy::module does too. This makes it more consistent. It also explicitly sets the feature where needed. This was explained in an issue[1]. [1]: theforeman#773 (comment)
ekohl
force-pushed
the
change-module-feature
branch
from
ea33f93
to
89d5acf
Compare
|
I think both are now addressed. |
evgeni
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foreman_proxy::plugin::module uses $title.capitalize() and now foreman::module does too. This makes it more consistent. It also explicitly sets the feature where needed. This was explained in an issue1.