Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require the grub packages before copying files on RedHat too #796

Merged
merged 1 commit into from Jan 25, 2023

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jan 25, 2023

this was done on Debian-family systems already, but not on RedHat, resulting in "double" errors if the package could not be installed:

/Stage[main]/Foreman_proxy::Tftp::Netboot/Package[grub2-efi-x64]/ensure: change from 'purged' to 'present' failed: Execution of '/bin/dnf -d 0 -e 1 -y install grub2-efi-x64' returned 1: Error: Unable to find a match: grub2-efi-x64
/Stage[main]/Foreman_proxy::Tftp::Netboot/File[/var/lib/tftpboot/grub2/grubx64.efi]: Could not evaluate: Could not retrieve information from environment production source(s) file:///boot/efi/EFI/redhat/grubx64.efi

this was done on Debian-family systems already, but not on RedHat,
resulting in "double" errors if the package could not be installed:

    /Stage[main]/Foreman_proxy::Tftp::Netboot/Package[grub2-efi-x64]/ensure: change from 'purged' to 'present' failed: Execution of '/bin/dnf -d 0 -e 1 -y install grub2-efi-x64' returned 1: Error: Unable to find a match: grub2-efi-x64
    /Stage[main]/Foreman_proxy::Tftp::Netboot/File[/var/lib/tftpboot/grub2/grubx64.efi]: Could not evaluate: Could not retrieve information from environment production source(s) file:///boot/efi/EFI/redhat/grubx64.efi
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like puppetlabs_spec_helper 5 has broken some things :(

@ekohl ekohl enabled auto-merge (rebase) January 25, 2023 16:09
@ekohl ekohl merged commit d76868e into theforeman:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants