Add Puppet 8 support

[bastelfreak]

No description provided.

[ekohl]

Please rebase.

[bastelfreak]

@ekohl done

[ekohl]

Needs voxpupuli/voxpupuli-acceptance#75

[bastelfreak]

restarted it again

[ekohl]

Looks like a packaging issue:

2023-11-07T11:47:24.7232127Z �[00;00m�[00;33m  Error: Execution of '/usr/bin/dnf -d 0 -e 1 -y install puppet-foreman_scap_client' returned 1: Error: 
2023-11-07T11:47:24.7233455Z    Problem: conflicting requests
2023-11-07T11:47:24.7234817Z     - nothing provides puppet >= 2.7.0 needed by puppet-foreman_scap_client-0.4.0-1.el8.noarch from foreman-plugins
2023-11-07T11:47:24.7243853Z �[00;00m�[00;33m  Error: /Stage[main]/Foreman_proxy::Plugin::Openscap/Package[puppet-foreman_scap_client]/ensure: change from 'purged' to 'present' failed: Execution of '/usr/bin/dnf -d 0 -e 1 -y install puppet-foreman_scap_client' returned 1: Error: 
2023-11-07T11:47:24.7245894Z    Problem: conflicting requests
2023-11-07T11:47:24.7247157Z     - nothing provides puppet >= 2.7.0 needed by puppet-foreman_scap_client-0.4.0-1.el8.noarch from foreman-plugins
2023-11-07T11:47:24.7283901Z �[00;00m�[00;33m  Notice: /Stage[main]/Foreman_proxy::Config/Foreman_proxy::Settings_file[settings]/File[/etc/foreman-proxy/settings.yml]/content: content changed '{sha256}e19a666b34a6d588785fc597940d507378a022596c5a46fb87d2d9286be93f12' to '{sha256}c91c7b401e1a87e3a45afbe66ee71b9445506fd406b0ff72e7bdd01ae2f15457'

puppet-agent no longer provides puppet, so the dependency is not satisfied.

[ekohl]

I did a puppet-foreman_scap_client 1.0.0 release and I'll fix up packaging during the update.

[ekohl]

theforeman/foreman-packaging#9955

[ekohl]

I'll still need to bump puppetlabs-stdlib

[ekohl]

theforeman/foreman-packaging#9964

[ekohl]

This should now pass.