Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #33751 - enable python and ostree content #387

Merged
merged 1 commit into from Oct 28, 2021

Conversation

jlsherrill
Copy link
Contributor

No description provided.

@@ -117,6 +121,8 @@
Boolean $enable_docker = true,
Boolean $enable_deb = true,
Boolean $enable_ansible = true,
Boolean $enable_python = true,
Boolean $enable_ostree = false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note i've defaulted ostree to false here, due to:

  1. we don't have a plugin package built yet, its been requested as part of the 3.16 builds
  2. it was disabled by default in katello previously, but i think it was due to the lack of an 'ostree' rpm being easily available. Its available in extras now

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it fails because it's missing here: https://github.com/theforeman/puppet-pulpcore/tree/master/manifests/plugin

It'd also be good to have a test where ostree is enabled to see that the catalog compiles.

@jlsherrill
Copy link
Contributor Author

yep, added here: theforeman/puppet-pulpcore#236

will add that test!

@jlsherrill
Copy link
Contributor Author

This is now 🟢

@evgeni
Copy link
Member

evgeni commented Oct 26, 2021

Can we wait with merging this until the 3.15 upgrade dust settled? I expect that to be done tomorrow.

@jlsherrill
Copy link
Contributor Author

works for me!

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder; is it ostree, Ostree or OSTree?

@evgeni
Copy link
Member

evgeni commented Oct 28, 2021

I do wonder; is it ostree, Ostree or OSTree?

yes

@jlsherrill
Copy link
Contributor Author

updated docs to use OSTree

@evgeni
Copy link
Member

evgeni commented Oct 28, 2021

But I think "OSTree" is the correct spelling, judging by upstream docs

manifests/init.pp Outdated Show resolved Hide resolved
@jlsherrill jlsherrill merged commit 79771d6 into theforeman:master Oct 28, 2021
@jlsherrill jlsherrill deleted the 33751 branch October 28, 2021 13:47
@ekohl
Copy link
Member

ekohl commented Oct 29, 2021

On a related note: do we need to enable it Katello as well? It's hard set to false here:
https://github.com/theforeman/puppet-katello/blob/5c2e8edf913f5d7df3852aaf90bcdc5560c82d1f/templates/katello.yaml.erb#L14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants