New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #33751 - enable python and ostree content #387
Conversation
@@ -117,6 +121,8 @@ | |||
Boolean $enable_docker = true, | |||
Boolean $enable_deb = true, | |||
Boolean $enable_ansible = true, | |||
Boolean $enable_python = true, | |||
Boolean $enable_ostree = false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note i've defaulted ostree to false here, due to:
- we don't have a plugin package built yet, its been requested as part of the 3.16 builds
- it was disabled by default in katello previously, but i think it was due to the lack of an 'ostree' rpm being easily available. Its available in extras now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it fails because it's missing here: https://github.com/theforeman/puppet-pulpcore/tree/master/manifests/plugin
It'd also be good to have a test where ostree is enabled to see that the catalog compiles.
yep, added here: theforeman/puppet-pulpcore#236 will add that test! |
This is now 🟢 |
Can we wait with merging this until the 3.15 upgrade dust settled? I expect that to be done tomorrow. |
works for me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do wonder; is it ostree, Ostree or OSTree?
yes |
updated docs to use OSTree |
But I think "OSTree" is the correct spelling, judging by upstream docs |
On a related note: do we need to enable it Katello as well? It's hard set to |
No description provided.