Remove katello-agent

[wbclark]

No description provided.

[ehelms]

Before we merge any of the changes, we will need staged updates for our pipeline tests, https://github.com/theforeman/forklift/blob/master/bats/fb-katello-client.bats#L10 and any other related katello-agent tests will need scoping. The puppet module tests now remove the testing of an enabled qpid being disabled so we should consider either:

1. Keeping a test here that first enables all the qpid bits and then tests that the module disables it properly
2. Add a pipeline upgrade test, similar to how we did Pulp 2 removal (https://github.com/theforeman/forklift/blob/master/pipelines/upgrade/07-server_to_final.yml#L24) that ensures katello-agent is enabled before the test upgrades to nightly / 4.10

@evgeni if you have any thoughts on this

[evgeni]

I think I'd prefer the forklift/bats route, as that's what users will be facing: having a 4.9 with k-a, upgrading to 4.10 and abandoning k-a.

[ekohl]

This is no longer correct.

[wbclark]

I could change this to 'Uninstall Qpid Dispatch Router' but this comment got me thinking that the class could just be removed and what little content remains could be moved into init.pp

[wbclark]

Thanks for the feedback @ekohl

I amended the commit with initial changes based on suggestions

I then added a second commit which further removes the dispatch_router class entirely, moving the little remaining code for cleanup into the base class.

I kept that as a 2nd commit for ease of review, but intend for it to be squashed before merging.

[ehelms]

I think this generally looks good, without a test with it setup and then running the module it's harder to tell if we missed something or not. I think in hindsight it would have been simpler to just leave all the code alone but enforce a false on the parameter. That would have reduce the variance being introduced and then allowed ripping all the code out in the following release.

@ekohl please also have a look

[wbclark]

Force pushed to squash commits