Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify package name handling #272

Merged
merged 1 commit into from Dec 14, 2018
Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Dec 12, 2018

f614db2 removed the use of $rubygem_katello_ostree variable, but not its definition.

We also don't want to hard fail because we sometimes want to compile on other distros. The most common use case is CI testing our installer by running it with --help. Since that happens on Travis (which is Ubuntu) it hard fails.

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehelms
Copy link
Member

ehelms commented Dec 13, 2018

Looks like some new test failures:

Failure/Error: it { expect { should contain_class('katello') }.to raise_error(Puppet::Error, /#{facts[:hostname]}: This module does not support osfamily #{facts[:osfamily]}/) }

f614db2 removed the use of
$rubygem_katello_ostree variable, but not its definition.

We also don't want to hard fail because we sometimes want to compile on
other distros. The most common use case is CI testing our installer by
running it with --help. Since that happens on Travis (which is Ubuntu)
it hard fails.
@ehelms ehelms merged commit 8eda970 into theforeman:master Dec 14, 2018
@ekohl ekohl deleted the package-names branch December 14, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants