Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #29817 - Implement a resizable hosts_queue pool #364

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Oct 19, 2020

This uses the new foreman::dynflow::pool defined type which allows users to easily add additional workers or scale them back.

Currently a draft since it's pointing to my branch in the fixtures to allow testing. Blocked on theforeman/puppet-foreman#843.

@ehelms
Copy link
Member

ehelms commented Oct 20, 2020

theforeman/puppet-foreman#843 allows users to control the concurrency and the number of workers, here I only see number of workers, is that an intended design to restrict it for this use case?

@ekohl
Copy link
Member Author

ekohl commented Oct 20, 2020

Not intentional, just a rushed patch here. @ianballou could you have a look about the desired config options and if this properly replaces your patch?

Also looks like I messed up the fixtures. Will update both once there's clarity about which params are expected.

@ianballou
Copy link
Contributor

@ekohl, it looks like this PR sufficiently covers my old one 👍

@ianballou
Copy link
Contributor

ianballou commented Feb 1, 2021

I'm curious what's going on with this PR, I haven't checked-in for a while. As far as I know we'd still like this functionality for Pulp 3 applicability calculations, but someone can let me know if we don't.

@ehelms
Copy link
Member

ehelms commented Apr 1, 2021

This can now be updated with theforeman/puppet-foreman#843 having been merged

@ekohl ekohl marked this pull request as ready for review April 7, 2021 13:03
@ekohl
Copy link
Member Author

ekohl commented Apr 7, 2021

Rebased to resolve merge conflicts and it depends on theforeman/foreman 17.x to ensure the correct API is present.

This uses the new foreman::dynflow::pool defined type which allows users
to easily add additional workers or scale them back.
@ehelms ehelms merged commit 271b5d8 into theforeman:master Apr 7, 2021
@ekohl ekohl deleted the 29817-dynflow-pool branch April 7, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants