Require puppet-certs 11+ #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
approved these changes
Feb 19, 2021
ekohl
reviewed
Mar 10, 2021
| @@ -26,7 +26,7 @@ | |||
| }, | |||
| { | |||
| "name": "katello/certs", | |||
| "version_requirement": ">= 9.0.0 < 11.0.0" | |||
| "version_requirement": ">= 11.0.0 < 12.0.0" | |||
There was a problem hiding this comment.
Why is version 11 required? Looking at the release log all the changes were in areas we don't touch in this module so normally I would expect it to be >= 9.0.0 < 12.0.0.
There was a problem hiding this comment.
That is fair. Looking at it, puppet-katello itself does not need 11.0.0, whereas puppet-foreman_proxy_content does need it. And these two modules are so tightly paired with having to exist together at the 'paired' versions that I just was thinking about that rather than what is 'technically' feasible for puppet-katello to work with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.