Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #34708 - configure certs for the katello agent broker #443

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Mar 31, 2022

No description provided.

@evgeni
Copy link
Member Author

evgeni commented Mar 31, 2022

the EL7 acceptance tests are failing because of qpid/epel 🙈

Copy link
Member

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had originally attempted to avoid specifying defaults to allow the app to determine that but I am can live with this.

@evgeni
Copy link
Member Author

evgeni commented Mar 31, 2022

I had originally attempted to avoid specifying defaults to allow the app to determine that but I am can live with this.

I mean, it does, just wrongly

https://github.com/Katello/katello/blob/dfacc81503e66aab70bb2131a25297f50ba611b6/lib/katello/engine.rb#L60-L67

@ehelms
Copy link
Member

ehelms commented Mar 31, 2022

I had originally attempted to avoid specifying defaults to allow the app to determine that but I am can live with this.

I mean, it does, just wrongly

https://github.com/Katello/katello/blob/dfacc81503e66aab70bb2131a25297f50ba611b6/lib/katello/engine.rb#L60-L67

Just the CA certificate.

@evgeni
Copy link
Member Author

evgeni commented Mar 31, 2022

Fair. Want me to only set CA? That's what's broken, the rest is just for consistency.

@ehelms
Copy link
Member

ehelms commented Apr 1, 2022

Fair. Want me to only set CA? That's what's broken, the rest is just for consistency.

Yes. No. Since user's have no installer options to change these values perhaps being explicit here is OK since it can help with debugging.

@ehelms ehelms merged commit d5cad7f into master Apr 1, 2022
@ehelms ehelms deleted the issue34708 branch April 1, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants