Verify successful bind when creating pulp_rpmbind #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves 2 problems * pulp-consumer rpm bind returns 0 even if the repo doesn't exist * Binding is asynchronous, so we should wait until it completes Fixes theforeman#276
ekohl
approved these changes
Oct 6, 2017
| @property_hash[:ensure] = :present | ||
| end | ||
|
|
||
| def destroy | ||
| consumer('rpm', 'unbind', '--repo-id', @resource[:name]) | ||
| @property_hash[:ensure] = :absent | ||
| end | ||
|
|
||
| def wait_for_bind | ||
| tries ||= 10 |
There was a problem hiding this comment.
I wonder if this should be configurable. What's your experience with how long the waiting typically takes?
There was a problem hiding this comment.
During my testing, the process was actually very quick. One 250ms wait was always enough for me. (IIRC I had to set the sleep to 0.01 to actually see more than one retry take place). But I figured it might not always be that fast depending on what else the system was doing at the time or because of network congestion etc. Waiting for no more than 2.5 seconds total seemed reasonable? If it doesn't complete by then, there's probably no point waiting any longer??
There was a problem hiding this comment.
That's fair and we can always fix it later.
|
Thanks! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-pulp
that referenced
this pull request
Jul 24, 2019
Solves 2 problems * pulp-consumer rpm bind returns 0 even if the repo doesn't exist * Binding is asynchronous, so we should wait until it completes Fixes theforeman#276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves 2 problems
Fixes #276