Use the non-deprecated namedspaced pg function

[ekohl]

No description provided.

[wbclark]

LGTM

[ekohl]

I'm not sure if this is backwards incompatible - I'd say enhancement. What makes you think it's incompatible? The min version bump?

[wbclark]

I'm not sure if this is backwards incompatible - I'd say enhancement. What makes you think it's incompatible? The min version bump?

Exactly. Someone using this module with puppetlabs/postgresql v4.2.0 would no longer be able to do that.

[ekohl]

While you may have a point, it's very inconvenient to consider every minimal version bump as a breaking change because it gets painful very quickly. https://semver.org/ only talks about the public API and the dependencies aren't really part of the public API. If someone requires puppetlabs/postgresql v4.2.0 and also theforeman/pulpcore $next_version then a dependency solver should inform the user about this. If they just need 1.x the solver should find 1.0.0.