Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #33766 - Support Pulpcore 3.15 #238

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Oct 21, 2021

No description provided.

Copy link
Member Author

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hear 3.16 is being worked on as well, but 3.15 is built today and is SCL'ed. On EL8 it also uses modules for Python 3.8. Having this PR allows us to verify we actually work.

manifests/plugin/certguard.pp Outdated Show resolved Hide resolved
@@ -140,7 +140,7 @@
# Modification should be performed incrementally to determine the least value that prevents false positive worker timeouts.
#
# @param use_rq_tasking_system
# Use the older RQ workers tasking system instead of the newer PostgreSQL tasking system introduced in Pulpcore 3.14.
# Use the older RQ workers tasking system instead of the newer PostgreSQL tasking system introduced in Pulpcore 3.14. This is deprecated in 3.15.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And will be removed in 3.16.

@ekohl
Copy link
Member Author

ekohl commented Oct 21, 2021

Looks like RQ is broken on EL7 with 3.15 but EL8 does pass. Perhaps some SCL issue.

@ehelms
Copy link
Member

ehelms commented Oct 21, 2021

You could go either way that this broken rq depending on how we think about exposing the command line tool. The tests use rq directly to inspect the state of the workers and that command does not exist outside the SCL context (e.g. https://github.com/theforeman/puppet-pulpcore/blob/master/spec/acceptance/enable_new_tasking_system_spec.rb#L65).

So we either update packaging to make an SCL aware rq or just update our tests to enable the SCL context on EL7. Or we stop testing RQ on EL7 knowing it's gone in 3.16.

@ekohl
Copy link
Member Author

ekohl commented Oct 21, 2021

Or we stop testing RQ on EL7 knowing it's gone in 3.16.

I'm leaning to the latter. We can even take the version into account here.

@ehelms ehelms mentioned this pull request Oct 24, 2021
2 tasks
this ensures the right SELinux context is set
and also allows to use the SCL (if there is any)
@evgeni
Copy link
Member

evgeni commented Oct 25, 2021

The RQ issue is simple to fix: #240

Since python3-certguard 1.4.0-3 this is solved in packaging. That clears
the path for Pulp 3.15.
@ekohl
Copy link
Member Author

ekohl commented Oct 25, 2021

This is now green. With the notes in README I would consider this a backwards compatible enhancement.

@ekohl ekohl changed the title Support Pulpcore 3.15 Fixes #33766 - Support Pulpcore 3.15 Oct 25, 2021
@ehelms ehelms merged commit 1685e07 into theforeman:master Oct 25, 2021
@ekohl ekohl deleted the 3.15-support branch October 25, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants