Fixes #34298 - support KEEP_CHANGELOG_LIMIT option #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Jan 24, 2022
There was a problem hiding this comment.
This feature belongs to the RPM plugin, so everything should be happening in pulpcore::plugin::rpm.
Here's an example where we set config for a plugin:
theforeman-bot
added
Waiting on contributor
Needs re-review
and removed
Not yet reviewed
Waiting on contributor
labels
|
I pushed a commit which addresses all feedback and moves the feature to pulpcore::plugin::rpm Will squash it after running all tests |
ekohl
reviewed
Jan 25, 2022
There was a problem hiding this comment.
Very small nits, but this is indeed what I expected. Please address them and squash the commit.
One thing that we can't do anything about, but I wonder if the Pulp setting should have been prefixed so it's RPM_KEEP_CHANGELOG_LIMIT. Or will pulp_deb also respect it? Just thinking out loud now.
wbclark
force-pushed
the
34298_KEEP_CHANGELOG_LIMIT
branch
from
fe6426e
to
739d0f4
Compare
ekohl
added
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added to Pulpcore with pulp/pulp_rpm#2333
Backport to 3.14 is underway