Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #35496 - Add default pulp_deb config #263

Merged
merged 1 commit into from Oct 28, 2022

Conversation

quba42
Copy link
Contributor

@quba42 quba42 commented Sep 7, 2022

https://projects.theforeman.org/issues/35496

For Katello users this is the sane/expected default behaviour. It allows
for the synchronization of partial Ubuntu mirrors, a very common use
case in the wild. Users often stumble over the error that is thrown for
such mirrors without this setting.

@quba42
Copy link
Contributor Author

quba42 commented Sep 7, 2022

Should I create a Katello issue to go with this change?

templates/settings.py.erb Outdated Show resolved Hide resolved
@ekohl
Copy link
Member

ekohl commented Sep 7, 2022

Should I create a Katello issue to go with this change?

It would be an installer issue. I always appreciate those since it helps with cherry picks.

@quba42 quba42 changed the title Always ignore missing package indices for APT repos within Katello Fixes #35496 - Add default pulp_deb config Sep 7, 2022
@quba42 quba42 requested a review from ekohl September 7, 2022 13:24
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is indeed the correct place.

You can also add a test. Either check for the concat fragment, like this:

is_expected.to contain_concat__fragment('plugin-ansible')
.with_content(%r{^ANSIBLE_API_HOSTNAME = "https://foo.example.com"})
.with_content(%r{^ANSIBLE_CONTENT_HOSTNAME = "https://foo.example.com/pulp/content"})

Or add .with_config('FORCE... = True') to contain_pulpcore__plugin('deb') here:

is_expected.to contain_pulpcore__plugin('deb')
.that_subscribes_to('Class[Pulpcore::Install]')
.that_notifies(['Class[Pulpcore::Database]', 'Class[Pulpcore::Service]'])

Looking at it now I'd go with the latter since it's easier and you're testing less for internal details.

manifests/plugin/deb.pp Outdated Show resolved Hide resolved
@ekohl
Copy link
Member

ekohl commented Oct 27, 2022

@quba42 we're about to release the module so we're ready for RC1. Any plan to finish this? Ideally speaking we'd release this module this week.

@quba42
Copy link
Contributor Author

quba42 commented Oct 28, 2022

Ugh totally forgot about this. I will have a look if I can quickly finish it now...

https://projects.theforeman.org/issues/35496

For Katello users this is the sane/expected default behaviour. It allows
for the synchronization of partial Ubuntu mirrors, a very common use
case in the wild. Users often stumble over the error that is thrown for
such mirrors without this setting.
@quba42
Copy link
Contributor Author

quba42 commented Oct 28, 2022

@ekohl Added your suggestions and a test (that I think makes sense)...

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Now I can do the release for Foreman 3.5 :)

@ekohl ekohl merged commit 5e2bfd7 into theforeman:master Oct 28, 2022
@ekohl ekohl added the Enhancement New feature or request label Oct 28, 2022
@quba42 quba42 deleted the pulp_deb_default branch October 28, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants