New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #35496 - Add default pulp_deb config #263
Conversation
Should I create a Katello issue to go with this change? |
It would be an installer issue. I always appreciate those since it helps with cherry picks. |
beb42f4
to
4ab28b8
Compare
4ab28b8
to
d377f24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This is indeed the correct place.
You can also add a test. Either check for the concat fragment, like this:
puppet-pulpcore/spec/classes/plugin_ansible_spec.rb
Lines 26 to 28 in 5858c93
is_expected.to contain_concat__fragment('plugin-ansible') | |
.with_content(%r{^ANSIBLE_API_HOSTNAME = "https://foo.example.com"}) | |
.with_content(%r{^ANSIBLE_CONTENT_HOSTNAME = "https://foo.example.com/pulp/content"}) |
Or add .with_config('FORCE... = True')
to contain_pulpcore__plugin('deb')
here:
puppet-pulpcore/spec/classes/plugin_deb_spec.rb
Lines 19 to 21 in 5858c93
is_expected.to contain_pulpcore__plugin('deb') | |
.that_subscribes_to('Class[Pulpcore::Install]') | |
.that_notifies(['Class[Pulpcore::Database]', 'Class[Pulpcore::Service]']) |
Looking at it now I'd go with the latter since it's easier and you're testing less for internal details.
@quba42 we're about to release the module so we're ready for RC1. Any plan to finish this? Ideally speaking we'd release this module this week. |
Ugh totally forgot about this. I will have a look if I can quickly finish it now... |
05faf0f
to
52b063e
Compare
https://projects.theforeman.org/issues/35496 For Katello users this is the sane/expected default behaviour. It allows for the synchronization of partial Ubuntu mirrors, a very common use case in the wild. Users often stumble over the error that is thrown for such mirrors without this setting.
52b063e
to
00b0f47
Compare
@ekohl Added your suggestions and a test (that I think makes sense)... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Now I can do the release for Foreman 3.5 :)
https://projects.theforeman.org/issues/35496
For Katello users this is the sane/expected default behaviour. It allows
for the synchronization of partial Ubuntu mirrors, a very common use
case in the wild. Users often stumble over the error that is thrown for
such mirrors without this setting.