Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #35607 - Configure Pulpcore's TELEMETRY setting #267

Merged
merged 1 commit into from Oct 25, 2022

Conversation

wbclark
Copy link
Collaborator

@wbclark wbclark commented Oct 7, 2022

See pulp/pulpcore#3115 for a description of what the telemetry reporting does and how it is configured.

This requires #266 and I haven't added any tests yet so I'm marking it as a draft for now.

@wbclark wbclark marked this pull request as draft October 7, 2022 08:03
@wbclark wbclark mentioned this pull request Oct 7, 2022
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

manifests/init.pp Outdated Show resolved Hide resolved
templates/settings.py.erb Outdated Show resolved Hide resolved
@ianballou
Copy link
Contributor

I made a community post about eventually moving to an opt-out model for Pulp Telemetry: https://community.theforeman.org/t/pulpcore-telemetry-and-katello/30920

@ehelms
Copy link
Member

ehelms commented Oct 24, 2022

Generally I think this looks good, needs a rebase.

@wbclark wbclark marked this pull request as ready for review October 25, 2022 19:03
@wbclark
Copy link
Collaborator Author

wbclark commented Oct 25, 2022

Rebased and marked ready for review

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ekohl ekohl merged commit 54ee9bf into theforeman:master Oct 25, 2022
@ekohl ekohl added the Enhancement New feature or request label Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants