Expose Apache server aliases as a parameter #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows setting a CNAME.
ekohl
force-pushed
the
expose-serveraliases
branch
from
a77b922
to
a89fbdf
Compare
ekohl
commented
Nov 1, 2022
| @@ -79,7 +79,7 @@ | |||
| it 'configures apache' do | |||
| is_expected.to contain_class('pulpcore::apache') | |||
| is_expected.to contain_apache__vhost('pulpcore') | |||
| is_expected.not_to contain_apache__vhost__fragment('pulpcore-http-pulpcore') | |||
There was a problem hiding this comment.
The bugs you find reading code. Turns out I was the one to blame.
ehelms
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows setting a CNAME.
Passing the aliases to Apache is especially important when there are multiple vhosts or when using mod_md. While today we don't do either, having the option is good. It can also help with debugging since sosreport does collect the vhosts, but not the certificates. If ServerAliases matches what's on the certificate, that can give a hint.
Currently still working on tests.