Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #28904 - make REMOTE_USER_ENVIRON_NAME configurable #61

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Fixes #28904 - make REMOTE_USER_ENVIRON_NAME configurable #61

merged 1 commit into from
Jan 31, 2020

Conversation

synkd
Copy link
Contributor

@synkd synkd commented Jan 30, 2020 •
edited
Loading

Fixes #28904

ekohl
ekohl reviewed Jan 30, 2020
View reviewed changes
manifests/init.pp Outdated Show resolved Hide resolved
@synkd synkd force-pushed the REMOTE_USER_ENVIRON_NAME branch 3 times, most recently from 49cfbe3 to 1b6b7c6 Compare January 30, 2020 21:07
@synkd synkd changed the title Make REMOTE_USER_ENVIRON_NAME configurable Fixes #28904 - make REMOTE_USER_ENVIRON_NAME configurable Jan 30, 2020
ekohl
ekohl requested changes Jan 30, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write a test for this? I think something like this probably works if you add it to spec/classes/pulpcore_spec.rb:

it { is_expected.to contain_concat__fragment('base').without_content(/REMOTE_USER_ENVIRON_NAME/) }

Of course you can also add a test case where you do pass it in to ensure it does show up then.

templates/settings.py.erb Outdated Show resolved Hide resolved
templates/settings.py.erb Outdated Show resolved Hide resolved
@synkd synkd force-pushed the REMOTE_USER_ENVIRON_NAME branch 3 times, most recently from 1f35968 to af05c1b Compare January 30, 2020 22:54
wbclark
wbclark reviewed Jan 30, 2020
View reviewed changes
templates/settings.py.erb Outdated Show resolved Hide resolved
ekohl
ekohl reviewed Jan 31, 2020
View reviewed changes
manifests/init.pp Outdated Show resolved Hide resolved
wbclark
wbclark approved these changes Jan 31, 2020
View reviewed changes
Copy link
Collaborator

@wbclark wbclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @synkd !

@ehelms ehelms merged commit 9c7219c into theforeman:master Jan 31, 2020
ekohl
ekohl approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you want to go for bonus points, then you can add a positive test where you set it and expect the content to be there.

@wbclark wbclark mentioned this pull request Jan 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbclark wbclark wbclark approved these changes

@ekohl ekohl ekohl approved these changes

@ehelms ehelms ehelms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@synkd @ekohl @ehelms @wbclark