Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare acceptance tests for EL8 #75

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Prepare acceptance tests for EL8 #75

merged 1 commit into from
Mar 9, 2020

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Mar 4, 2020

Also updates the SCL from pg 10 to 12.

Copy link
Collaborator

@wbclark wbclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ekohl .

Code looks good to me - please allow some time for me to check it out and play with it before merging.

@ehelms
Copy link
Member

ehelms commented Mar 6, 2020

Can this be tied back to the Redmine issue that @wbclark has tracking EL8 support across modules?

Also updates the SCL from pg 10 to 12.
@ekohl
Copy link
Member Author

ekohl commented Mar 6, 2020

Updated

Copy link
Collaborator

@wbclark wbclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this PR, I am able to run el8 acceptance tests on centos8-64 with the vagrant-libvirt backend: $ BEAKER_HYPERVISOR=vagrant_libvirt BEAKER_provision=yes BEAKER_destroy=no BEAKER_setfile=centos8-64 bundle exec rspec spec/acceptance/basic_spec.rb

Currently, the tests fail on el8 due to Error: /Stage[main]/Pulpcore::Install/Package[pulpcore-selinux]/ensure: change from 'purged' to 'present' failed: Execution of '/usr/bin/dnf -d 0 -e 1 -y install pulpcore-selinux' returned 1: Error: Unable to find a match

I don't believe that should block this from being merged.

@ehelms ehelms merged commit 0687005 into theforeman:master Mar 9, 2020
@ekohl ekohl deleted the el8 branch March 9, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants