Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Pin Facter to < 4" #83

Closed
wants to merge 1 commit into from
Closed

Revert "Pin Facter to < 4" #83

wants to merge 1 commit into from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Mar 20, 2020

This reverts commit 011f84b. It temporarily uses the experimental_exit to test whether that fixes it.

cc @IrimieBogdan

@ekohl ekohl mentioned this pull request Mar 20, 2020
Closed
@ekohl
Copy link
Member Author

ekohl commented Mar 20, 2020

The Puppet 5 failure is irrelevant. On Puppet 6 it looks like it still output the error but doesn't fail.

wbclark
wbclark reviewed Mar 20, 2020
View reviewed changes
Gemfile Outdated Show resolved Hide resolved
wbclark
wbclark approved these changes Mar 20, 2020
View reviewed changes
Copy link
Collaborator

@wbclark wbclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really great to see the quick action on this.

I think the issue with Puppet 5 will disappear once facter is updated and we don't need to pull the alternate branch from GH. In that case, ACK.

@ekohl
Revert "Pin Facter to < 4"
86e3791 
This reverts commit 011f84b.
@ekohl ekohl marked this pull request as ready for review April 2, 2020 13:15
@ekohl
Copy link
Member Author

ekohl commented Apr 2, 2020

Ready for review now.

@mmoll mmoll closed this Apr 2, 2020
@mmoll mmoll reopened this Apr 2, 2020
@mmoll
Copy link
Contributor

mmoll commented Apr 2, 2020

@ekohl Travis reporting seems broken, could you open this as another PR?

@ekohl ekohl mentioned this pull request Apr 3, 2020
Merged
@ekohl ekohl closed this Apr 3, 2020
@ekohl ekohl deleted the facter-4 branch April 3, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmoll mmoll mmoll approved these changes

@wbclark wbclark wbclark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ekohl @mmoll @wbclark