Don't set config_version to server_config_version for every environment

[mcanevet]

There is no need to default config_version to server_config_version for puppet::server::env because the default behavior is to take the config_version from the master section

[domcleal]

I haven't verified the default behaviour that @mcanevet mentioned, but otherwise looks fine.

[ekohl]

Do we have the config_version by default in master? If so, 👍

[domcleal]

Hmm, seems we don't. It's only set when using git or dynamic environments:

https://github.com/theforeman/puppet-puppet/blob/master/templates/server/puppet.conf.erb#L17-L21

Whereas in server::env it's always added if the parameter is set.

[mcanevet]

Not relevant anymore. I close.