remove useless parameter server_passenger_max_pool #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timogoebel
changed the title
|
It should be possible to pass this to a vhost, though puppetlabs-apache doesn't support it. Since I introduced this feature and broke it when refactoring to puppetlabs-apache, I'm fine with removing it. |
|
@ekohl : According to https://www.phusionpassenger.com/library/config/apache/reference/#passengermaxpoolsize it's only valid in "server config" context. |
|
👍 then. |
|
@timogoebel then maybe it used to work before because it was placed outside of the vhost. 👍 on green tests. |
|
merged, danke @timogoebel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mmoll: Just some cleanup :-)
passenger_max_poolis a global passenger setting which we do not want to support. The parameter is not passed through to puppetlabs-apache module and therefore has no effect.