Feature 2307 - Include ::daemon or ::cron classes based on runmode param value #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 12, 2013 14:51
* Added a $runmode param which defaults to 'service'. * Created paramater in init class. * Added a case statement to config class to include relevant class based on runmode value.
setups which have puppet and puppet::cron defined.
| include ::puppet::cron | ||
| } | ||
| default: { | ||
| fail("Runmode of ${puppet::runmode} not supported by puppet::config!") |
There was a problem hiding this comment.
Incredibly nit-picky, I know, but this should be ${::puppet::runmode} :-)
There was a problem hiding this comment.
Doh... Have fixed this else-where and then done it here... Fixing now :)
|
Looks good, apart from the most tiny change ever. @domcleal ? |
|
Merged, thanks for the patch @fatmcgav! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated code to add a 'runmode' param which can be used to set Puppet agent up as using ::Cron or ::daemon classes based on value.