Revised patch to allow puppet::server to be used without foreman (obsoletes PR #73) #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,8 +1,6 @@ | |||
| # Default parameters | |||
| class puppet::params { | |||
|
|
|||
| include foreman::params | |||
There was a problem hiding this comment.
Don't we need this line because we use it in our server.pp for defaults? Looking at those, I think we should look at moving them. puppet_home and puppet_basedir sounds more like puppet than foreman to me.
|
@robinbowes in f2e8737 I added tests and you can build on that. If you have no interest in working on this, that's OK and we'll just merge this with the fix in server.pp. |
|
I ended up changing solution and not using this module so am not in a position to work on it just now. Sorry. |
|
@Reconnix no problem, thanks for letting me know. |
|
I've opened #83 to integrate this suggestion and added some tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.