Correct Type Validation of server_foreman_ssl* #754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream ::foreman::puppetmaster class correctly allows empty strings for these parameters for Foreman instances that don't require mutual TLS authentication for this purpose. The change is already made there. Just matching it here.
ekohl
approved these changes
Jul 29, 2020
|
Thanks! I'll just let Travis finish before merging. |
|
@ekohl found another spot where it needed updating so sorry Travis will run again I imagine XD |
|
Found more issues on my side, will close and resubmit when more complete |
|
@jstewart612 Was this ever resubmitted in a different PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream ::foreman::puppetmaster class correctly allows empty strings for these parameters for Foreman instances that don't require mutual TLS authentication for this purpose. The change is already made there. Just matching it here.