Drop Puppet 6 support #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mind cleaning up the README as well? There are few mentions of lowest supported version and an upgrade guide that is no longer relevant. |
|
Good point. Updated and made some adjustments to the tests to make them pass. |
|
All green now. |
|
you didn't remove enough lines 😝 Line 5 in 5050652 Line 9 in 5050652 puppet-puppet/manifests/server.pp Line 271 in 2ef1b86 |
The default was changed and init.pp was updated, but server.pp wasn't. Fixes: 95788e3 ("Fixes #35728 - Disable telemetry by default")
evgeni
approved these changes
May 16, 2023
There was a problem hiding this comment.
puppet-puppet/manifests/init.pp
Line 574 in 2ef1b86
I think that's the last one, but also kinda unimportant :)
|
Now also with puppetlabs/puppetserver@240a459 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.