Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling CRL checking on agent #887

Merged
merged 1 commit into from Oct 19, 2023
Merged

Allow disabling CRL checking on agent #887

merged 1 commit into from Oct 19, 2023

Conversation

cm-jc
Copy link
Contributor

@cm-jc cm-jc commented Sep 13, 2023

In extrernal CA configurations, it is possible that a CRL is not present on the server. This allows to tell the agent to skip downloading it and checking it.

@cm-jc
Allow disabling CRL checking on agent
4fd2a40 
In extrernal CA configurations, it is possible that a CRL is not present
on the server. This allows to tell the agent to skip downloading it and
checking it.
@cm-jc
Copy link
Contributor Author

cm-jc commented Sep 22, 2023

@ekohl , Can I get a review?

ekohl
ekohl approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing this. You can also call puppet::config::main in your own module or use $additional_settings (via Hiera), but I like data types for proper validation so 👍.

@ekohl ekohl merged commit 7344e3f into theforeman:master Oct 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cm-jc @ekohl @theforeman-bot