Fixes #30252: Make wait for port more resilient #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
reviewed
Nov 16, 2020
The current method can result in journal error messages: [System] error Error reading socket: Encountered end of file [-5938] This updated version waits and checks for listening ports and greps for the port in question to appear before signaling that the service is ready.
|
Thanks @evgeni for that point out, I have updated it and the tests. |
evgeni
approved these changes
Nov 17, 2020
ekohl
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
This probably also solved https://projects.theforeman.org/issues/27637 or at least make it invalid.
|
Agree, it should fix that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current method can result in journal error messages:
[System] error Error reading socket: Encountered end of file [-5938]
This updated version waits and checks for listening ports
and greps for the port in question to appear before signaling
that the service is ready.