New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refs #32037: Add parameters to disable qpid services #148
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,10 @@ | |
# Frequency in seconds of sending heartbeats from this router | ||
# @param hello_max_age | ||
# Timeout of heartbeat before connections are dropped | ||
# @param service_enable | ||
# Enable/disable qdrouterd service at boot | ||
# @param service_ensure | ||
# Specify if qdrouterd should be running or stopped. | ||
class qpid::router( | ||
$router_id = $qpid::router::params::router_id, | ||
$mode = $qpid::router::params::router_mode, | ||
|
@@ -25,6 +29,8 @@ | |
$worker_threads = $qpid::router::params::worker_threads, | ||
$hello_interval = $qpid::router::params::hello_interval, | ||
$hello_max_age = $qpid::router::params::hello_max_age, | ||
$service_ensure = true, | ||
$service_enable = undef, | ||
Comment on lines
+32
to
+33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would have liked to see data types here. Ideally whenever you add a parameter, you use a data type. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Given this class did not have data types already, it was either add it just for these two, add it for all (and possibly overreach the point of the PR) or stick with what was present already. I chose the latter to make the focused changed. And plan to follow up adding types. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. #152 for those reading along :) |
||
) inherits qpid::router::params { | ||
|
||
contain qpid::router::install | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice additional fix that we should have caught earlier