Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #11285 - require qpid-cpp-server-linearstore #26

Merged
merged 1 commit into from Oct 20, 2015

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Aug 4, 2015

No description provided.

@@ -22,5 +22,5 @@
$user = 'qpidd'
$group = 'qpidd'

$server_packages = ['qpid-cpp-server', 'qpid-cpp-client', 'python-qpid-qmf', 'python-qpid', 'policycoreutils-python', 'qpid-tools']
$server_packages = ['qpid-cpp-server', 'qpid-cpp-client', 'python-qpid-qmf', 'python-qpid', 'policycoreutils-python', 'qpid-tools', 'qpid-cpp-server-linearstore']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know older qpids (which katello doesn't use anymore) use qpid-cpp-server-store instead of linear-store. Do we want to try to support that? (The answer doesn't have to be yes)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still in EPEL? I think it makes sense, this should probably be parameter and give the option of providing a store or not (same for things like installing the client, tools, etc).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is in epel 7:
https://dl.fedoraproject.org/pub/epel/7/x86_64/repoview/qpid-cpp-server-store.html

On Tue, Aug 4, 2015 at 10:36 PM, Stephen Benjamin notifications@github.com
wrote:

In manifests/params.pp
#26 (comment):

@@ -22,5 +22,5 @@
$user = 'qpidd'
$group = 'qpidd'

  • $server_packages = ['qpid-cpp-server', 'qpid-cpp-client', 'python-qpid-qmf', 'python-qpid', 'policycoreutils-python', 'qpid-tools']
  • $server_packages = ['qpid-cpp-server', 'qpid-cpp-client', 'python-qpid-qmf', 'python-qpid', 'policycoreutils-python', 'qpid-tools', 'qpid-cpp-server-linearstore']

Is it still in EPEL? I think it makes sense, this should probably be
parameter and give the option of providing a store or not (same for things
like installing the client, tools, etc).


Reply to this email directly or view it on GitHub
https://github.com/Katello/puppet-qpid/pull/26/files#r36265118.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but actually so is linear store.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the status of this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with merging as is (after rebase)

@stbenjam
Copy link
Member Author

Updated, the store being installed is configurable, as is the package name, so we can support older qpids

@ehelms
Copy link
Member

ehelms commented Oct 20, 2015

ACK

@stbenjam
Copy link
Member Author

Thanks

stbenjam added a commit that referenced this pull request Oct 20, 2015
fixes #11285 - require qpid-cpp-server-linearstore
@stbenjam stbenjam merged commit 8181cab into theforeman:master Oct 20, 2015
@stbenjam stbenjam deleted the 11285 branch October 20, 2015 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants