Make migrations compatible with settings category removal

[stejskalleos]

See:

theforeman/foreman#9524
theforeman/foreman#9524 (comment)

[ekohl]

It still fails. Looks like this also needs a change:

puppetdb_foreman/db/migrate/20170717140010_migrate_puppetdb_api_version_setting.rb

Line 9 in 19ade1f

setting = Setting.where(category: 'Setting::Puppetdb', name: 'puppetdb_api_version').first_or_create

[stejskalleos]

Migrations fixed, but now it's failing on webpack:

Can't find our webpack executable at /home/jenkins/workspace/puppetdb_foreman-pull-request/label/fast/ruby/2.7/foreman/node_modules/.bin/webpack - have you run `npm install`?
/home/jenkins/workspace/puppetdb_foreman-pull-request/label/fast/ruby/2.7/foreman/lib/tasks/webpack_compile.rake:19:in `block (2 levels) in <top (required)>'

Why is webpack involved?

[ekohl]

That's a good question, since there is no package.json it shouldn't have any webpack resources. It's probably fallout from
theforeman/jenkins-jobs@ebfdda2 where $database was previously undefined, but now rake jenkins:integration is run unconditionally. And jenkins:integration pulls in webpack:compile: https://github.com/theforeman/foreman/blob/4381a7bb7fadf5c3c11f0976343b1b025edf5039/lib/tasks/jenkins.rake#L6

[ekohl]

I opened theforeman/jenkins-jobs#337 which I think should fix it.

[ekohl]

[test puppetdb_foreman]

[ekohl]

[test puppetdb_foreman]