Fixes #14158 - Add tailoring file for scans #39
Conversation
|
I added proxy plugin to foreman_infra, I think we need to add a webhook for jenkins in repo settings to enable testing on PRs. |
|
I just released ruby-openscap-0.4.7. You may want to amend your gemfile to depend on 0.4.7. |
xprazak2
force-pushed
the
tailoring
branch
2 times, most recently
from
796d88b
to
ee18a81
Compare
|
I updated the dependency version, thanks @isimluk! |
| @@ -21,6 +21,7 @@ class Plugin < ::Proxy::Plugin | |||
| :openscap_send_log_file => File.join(APP_ROOT, 'logs/openscap-send.log'), | |||
| :contentdir => File.join(APP_ROOT, 'openscap/content'), | |||
| :reportsdir => File.join(APP_ROOT, 'openscap/reports'), | |||
| :failed_dir => File.join(APP_ROOT, 'openscap/failed') | |||
| :failed_dir => File.join(APP_ROOT, 'openscap/failed'), | |||
| :tailoringdir => File.join(APP_ROOT, 'openscap/tailoring') | |||
There was a problem hiding this comment.
Could you please rename this to tailoring_dir? I see there are others without underscore, but Ruby convention is to separate words.
| @@ -97,9 +108,19 @@ class Api < ::Sinatra::Base | |||
| end | |||
| end | |||
|
|
|||
| post "/scap_content/validator" do | |||
There was a problem hiding this comment.
I think we should keep compatibility here at least for 1 release. Could you keep /scap_content/validator that would print deprecation warning and call /scap_file/validator/scap_content? Also opening redmine issue to remove this in 0.5 would be great.
|
I renamed |
|
I still see |
|
I opened the tracking issue and removed it from code - hopefully for good this time. |
|
👍 works fine with older version of foreman_openscap and prints the deprecation warning, ready for merge |
|
[test] |
|
[test] master is green again |
Will need this to work.