Allow connecting to arbitrary domain DC

adcli will automatically grab SRV records to decide on a DC to connect to if not given an explicit DC FQDN With this change it would be as simple as not providing a `:domain_controller` value in the config
theforeman · Oct 4, 2018 · ca36312 · ca36312
1 parent d12c77c
commit ca36312
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/smart_proxy_realm_ad/plugin.rb b/lib/smart_proxy_realm_ad/plugin.rb
@@ -7,7 +7,7 @@ class Plugin < Proxy::Provider
     load_classes ::Proxy::AdRealm::ConfigurationLoader
     load_dependency_injection_wirings ::Proxy::AdRealm::ConfigurationLoader
 
-    validate_presence :realm, :keytab_path, :principal, :domain_controller
+    validate_presence :realm, :keytab_path, :principal
     validate_readable :keytab_path
 
     plugin :realm_ad, ::Proxy::AdRealm::VERSION

diff --git a/lib/smart_proxy_realm_ad/provider.rb b/lib/smart_proxy_realm_ad/provider.rb
@@ -88,7 +88,7 @@ def radcli_connect
       # Connect to active directory
       conn = Adcli::AdConn.new(@domain)
       conn.set_domain_realm(@realm)
-      conn.set_domain_controller(@domain_controller)
+      conn.set_domain_controller(@domain_controller) unless @domain_controller.nil?
       conn.set_login_ccache_name('')
       conn.connect
       conn