Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #35541 - Mark session as closed after run_sync when using async_ssh #94

Merged
merged 1 commit into from Sep 26, 2022
Merged

Fixes #35541 - Mark session as closed after run_sync when using async_ssh #94

merged 1 commit into from Sep 26, 2022

Conversation

adamruzicka
Copy link
Contributor

No description provided.

ianballou
ianballou approved these changes Sep 23, 2022
View reviewed changes
Copy link

@ianballou ianballou left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against a 6.11 machine, works well. After applying, I was able to run async ssh commands on my el8 host.

@adamruzicka adamruzicka merged commit d5c1863 into theforeman:0.5-stable Sep 26, 2022
@adamruzicka
Copy link
Contributor Author

Thank you @ianballou !

@adamruzicka adamruzicka deleted the 0.5/session-close branch September 26, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianballou ianballou ianballou approved these changes

Assignees
No one assigned
Labels
Waiting on contributor
Projects
None yet
Milestone
No milestone
3 participants
@adamruzicka @ianballou @theforeman-bot