This repository has been archived by the owner on Nov 22, 2021. It is now read-only.
Make sure assignment does not leave host with wrong state on exception #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| host.type = 'Host::Managed' | ||
| host.managed = true | ||
| host.build = true | ||
| original_type = discovered_host.type |
There was a problem hiding this comment.
nitpick: can we use rails dirty cache like discovered_host.type_was for this?
There was a problem hiding this comment.
I am not sure how this works in combination with #becomes. The attribute hash is shared between those objects. I was worried that it might now work. Update: i've tested, it does not work. type_was returns nil instead of original value :(
|
Broken, fixing ... |
sseago
added a commit
that referenced
this pull request
Apr 22, 2014
Make sure assignment does not leave host with wrong state on exception
|
@sseago please revert this, it is not working. |
|
@pitr-ch Yes, sorry. I misread your "fixing" comment as "fixed". -- sorry. We're trying to get the (ready to go) stuff on master for another build and were a bit too enthusiastic here. |
|
Thanks, I'll fix this tomorrow. It's not critical. |
knowncitizen
added a commit
that referenced
this pull request
Apr 22, 2014
Revert "Merge pull request #87 from pitr-ch/master"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ares