Update procedures for Copr workflow #285
Conversation
ehelms
force-pushed
the
copr-update-procedures
branch
from
ae47071
to
c5b2061
Compare
|
|
||
| - [ ] Run `./tools.rb koji configs/katello/<%= release %>.yaml --confirm` from [tool_belt](https://github.com/theforeman/tool_belt) to create Koji tags | ||
| - [ ] Run `./tools.rb mash-scripts configs/katello/<%= release %>.yaml` from [tool_belt](https://github.com/theforeman/tool_belt) to create Koji mash configs and open PR to tool_belt to commit | ||
| - [ ] Copy mash configs to Koji using <%= rel_eng_script('deploy_mash_configs') %> |
There was a problem hiding this comment.
This whole section is now inherently built into the Foreman release process that at the time of branching rpm/develop will fork all of the nightly repositories to a versioned repository -- https://github.com/theforeman/theforeman-rel-eng/pull/285/files#diff-d061c99b19d953d05d43c2de1a7199aac667795ed8a2e9c7991cef788118b7f8R74
|
@ekohl Do you want to see the new methods wrapped with conditionals based on version? For procedures that affect z-stream releases? |
ehelms
force-pushed
the
copr-update-procedures
branch
from
c5b2061
to
a64c4b5
Compare
ehelms
force-pushed
the
copr-update-procedures
branch
from
a64c4b5
to
705e600
Compare
|
Rebased and updated with version checks for the release procedure. The branch procedure only happens for a Y-releases so it does not need version checks on the procedure like the release procedure does. |
ehelms
force-pushed
the
copr-update-procedures
branch
from
705e600
to
b5b5900
Compare
ehelms
force-pushed
the
copr-update-procedures
branch
from
b5b5900
to
9f61ba4
Compare
| @@ -1,7 +1,6 @@ | |||
| ## Roles | |||
|
|
|||
| * Release Owner: <%= owner %> | |||
| * Release Engineer: <%= engineer %> | |||
There was a problem hiding this comment.
A note: the script will still prompt for this. We can leave it out of scope for this PR, but something we should eventually deal with.
There was a problem hiding this comment.
This whole document needs an update now that it works based on rpm/develop and uses branching from that. Also still references tito.
ehelms
force-pushed
the
copr-update-procedures
branch
from
9f61ba4
to
79b05de
Compare
There was a problem hiding this comment.
I wonder what https://github.com/theforeman/jenkins-jobs/blob/master/branch-foreman does. I've opened theforeman/jenkins-jobs#376 in a way that I think makes it work.
| - [ ] Create a `rpm/<%= release %>` branch in [foreman-packaging](https://github.com/theforeman/foreman-packaging) based on `rpm/develop`: `git checkout rpm/develop && git pull && git checkout -b rpm/<%= release %>` | ||
| - [ ] Update `foreman_version` in `package_manifest.yaml` on the `rpm/<%= release %>` branch: `sed -i '/foreman_version:/ s/nightly/<%= release %>/' package_manifest.yaml` | ||
| - [ ] Update `katello_version` in `package_manifest.yaml` on the `rpm/<%= release %>` branch: `sed -i '/katello_version:/ s/nightly/KATELLO_VERSION_HERE/' package_manifest.yaml | ||
| - [ ] Create release repositories in Copr by forking nightly repositories `obal copr-project copr_projects` on the `rpm/<%= release %>` branch |
There was a problem hiding this comment.
This will require the release engineer to have a working copr cli setup and the right permissions.
I do not recall if we document this properly today for koji (probably not), but worth fixing this now :)
There was a problem hiding this comment.
We do not have this documented... should it be here? Should it be on foreman-packaging (pulpcore-packaging, etc?)? Somewhere else more central?
There was a problem hiding this comment.
I think I'd prefer it here, at least what level of access is required for which system, how to obtain it might not necessarily be here (but I won't be opposed if it is)
ehelms
force-pushed
the
copr-update-procedures
branch
from
79b05de
to
e6eaa60
Compare
ehelms
force-pushed
the
copr-update-procedures
branch
from
e6eaa60
to
ae3a8c3
Compare
There was a problem hiding this comment.
We also need to edit https://github.com/theforeman/theforeman-rel-eng#foreman-release-engineer to list COPR access for release engineers. I'm not sure how permissions work there, but some admin needs to make sure new release engineers have the right permissions.
ehelms
force-pushed
the
copr-update-procedures
branch
2 times, most recently
from
f332f8f
to
b6468b5
Compare
I added a link to where we set those values at least to indicate you need to be in that list or hint at contacting someone who is. |
ehelms
force-pushed
the
copr-update-procedures
branch
2 times, most recently
from
ecef3a8
to
83f575f
Compare
ehelms
force-pushed
the
copr-update-procedures
branch
from
83f575f
to
cbb009a
Compare
No description provided.