Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for 1.18 #1100

Merged
merged 1 commit into from Jun 12, 2018
Merged

Conversation

xprazak2
Copy link
Contributor

@xprazak2 xprazak2 commented Jun 1, 2018

No description provided.

Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few inline comments, otherwise looks good!

Hosts can now be provisioned with RancherOS. ([#15634](http://projects.theforeman.org/issues/15634), [0ace99ee](http://github.com//foreman/commit/0ace99ee2cc11cfa4e0a7d69be9a411b83812e68), [5fc1b19a](http://github.com//foreman/commit/5fc1b19ae5d95ecd42379f46847ff4240bd618e9), [8c837777](http://github.com//community-templates/commit/8c83777715c1b7af9ec45e62332368a42e83ac0c))


#### Anonymize Audit logs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps combine this with the deletion as well (#22158)?


#### Web Interface
* Bump version of patternfly-react to support inline edits ([#23462](http://projects.theforeman.org/issues/23462), [f927833c](http://github.com//foreman/commit/f927833c5dafa6859afe009e29e2a04c8f7ae231), [e5ca4f3e](http://github.com//foreman/commit/e5ca4f3e05b4d0bec21478fa1cc72ff57befcc9b))
* Add redux container for breadcrumb switcher ([#22855](http://projects.theforeman.org/issues/22855), [833e2aef](http://github.com//foreman/commit/833e2aef24d6f3cb6eae90213ea198dd354a5709))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the breadcrumbs and resource switcher also deserve a headline

#### Compute resources - VMware
* VMware: Exception listing VMs in the root of the datacenter ([#22798](http://projects.theforeman.org/issues/22798), [68e96c10](http://github.com//foreman/commit/68e96c10b596d67106a3ed49535231019d8507b4))
* Rescue from errors on per-host basis when associating vmware VMs ([#21317](http://projects.theforeman.org/issues/21317), [7af7f44c](http://github.com//foreman/commit/7af7f44c3324bb93f2402b2cb528c23b5ccc5b06))
* Failed to update a compute vmware (VMware) instance node.test.domain: undefined method `[]' for nil:NilClass ([#19990](http://projects.theforeman.org/issues/19990), [1dbb2c5b](http://github.com//foreman/commit/1dbb2c5b319dbab023f3aaa98019d7b9cd0ee8f6))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the backtick here needs escaping for the markdown formatting to be correct

@xprazak2
Copy link
Contributor Author

xprazak2 commented Jun 5, 2018

I added breadcrumbs and cleaning audits into headline features, fixed the markup.

I will add contributors after we've tagged, our script uses the tags to generate the list.

@xprazak2 xprazak2 changed the title [WIP] Add release notes for 1.18 Add release notes for 1.18 Jun 8, 2018
@xprazak2
Copy link
Contributor Author

xprazak2 commented Jun 8, 2018

I added contributor list.

@mmoll
Copy link
Contributor

mmoll commented Jun 8, 2018

All the links should go directly to https://


#### RancherOS support

Hosts can now be provisioned with RancherOS. ([#15634](http://projects.theforeman.org/issues/15634), [0ace99ee](http://github.com//foreman/commit/0ace99ee2cc11cfa4e0a7d69be9a411b83812e68), [5fc1b19a](http://github.com//foreman/commit/5fc1b19ae5d95ecd42379f46847ff4240bd618e9), [8c837777](http://github.com//community-templates/commit/8c83777715c1b7af9ec45e62332368a42e83ac0c))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe https://rancher.com/rancher-os/ could get linked here


#### Add MTU support for subnets

MTU for subnets is now supported. ([#21694](http://projects.theforeman.org/issues/21694), [f175f751](http://github.com//foreman/commit/f175f7510d9e334c468ecfdcfc69c7a8485f21a1), [92c17a1a](http://github.com//foreman/commit/92c17a1a1ff6f6ed2d94b5ae13279634fa5127f2), [6b65706a](http://github.com//foreman/commit/6b65706af1b0604ddab98774c00391ccddea1fb7), [d313cc81](http://github.com//community-templates/commit/d313cc81632d6a26397800b61fa46ebcf69580d5))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a tad better: "Setting the MTU per subnet is now supported. The default will be 1500 (Ethernet default value)." or similar. Otherwise, without knowing what this change is about it's hard to understand at the first read, IMHO.

@xprazak2 xprazak2 force-pushed the eighteen-rel branch 3 times, most recently from ca7afa3 to b362104 Compare June 11, 2018 06:24
@xprazak2
Copy link
Contributor Author

The links go to https:// now and I added a link for RancherOS

@xprazak2 xprazak2 mentioned this pull request Jun 11, 2018

Hosts can now be provisioned with [RancherOS](https://rancher.com/rancher-os/). ([#15634](https://projects.theforeman.org/issues/15634), [0ace99ee](https://github.com//foreman/commit/0ace99ee2cc11cfa4e0a7d69be9a411b83812e68), [5fc1b19a](https://github.com//foreman/commit/5fc1b19ae5d95ecd42379f46847ff4240bd618e9), [8c837777](https://github.com//community-templates/commit/8c83777715c1b7af9ec45e62332368a42e83ac0c))

#### Anonymize Audit logs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This heading should also be changed, something like "Anonymize or clean audit logs"

@xprazak2
Copy link
Contributor Author

Updated.

Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xprazak2 !

@tbrisker tbrisker merged commit 4cad7c9 into theforeman:gh-pages Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants