Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update report templates manuals #1350

Merged

Conversation

ezr-ondrej
Copy link
Member

Explaining new features coming in 1.22 for report templates.
Any grammar checks would be helpful, even though I did my best 馃樃

Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some grammar corrections, otherwise looks good.


##### Planing and deliver via e-mail

In a generating form you can choose a time, for a generating start time. There is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In a generating form you can choose a time, for a generating start time. There is
In the report generation form you can choose a starting time for delayed generation. There is

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This I have rewritten a bit.

##### Planing and deliver via e-mail

In a generating form you can choose a time, for a generating start time. There is
no way to schedule repeated generating, but as the report generating can be started
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
no way to schedule repeated generating, but as the report generating can be started
no way to schedule repeated generation, but as the report generating can be started


In a generating form you can choose a time, for a generating start time. There is
no way to schedule repeated generating, but as the report generating can be started
by a *hammer report-template* command, the scheduling can be achieved from cron.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
by a *hammer report-template* command, the scheduling can be achieved from cron.
by a *hammer report-template* command, scheduling can be achieved using cron.


There's a separate permission for generating the report, so only selected users
can perform resource heavy operations while another users can prepare the report
templates.

##### Planing and deliver via e-mail
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
##### Planing and deliver via e-mail
##### Scheduling and delivering reports via e-mail

In a generating form you can choose a time, for a generating start time. There is
no way to schedule repeated generating, but as the report generating can be started
by a *hammer report-template* command, the scheduling can be achieved from cron.
For this planned repots, as well as for long running reports it is no longer useful
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For this planned repots, as well as for long running reports it is no longer useful
For these planned reports, as well as for long running reports, it is no longer useful

no way to schedule repeated generating, but as the report generating can be started
by a *hammer report-template* command, the scheduling can be achieved from cron.
For this planned repots, as well as for long running reports it is no longer useful
to have the report downloaded by web browser. In such cases you can choose to get
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to have the report downloaded by web browser. In such cases you can choose to get
to have the report downloaded by the web browser. In such cases you can choose to get

by a *hammer report-template* command, the scheduling can be achieved from cron.
For this planned repots, as well as for long running reports it is no longer useful
to have the report downloaded by web browser. In such cases you can choose to get
the report delivered via e-mail by simply checking a *Send report via e-mail* and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the report delivered via e-mail by simply checking a *Send report via e-mail* and
the report delivered via e-mail by simply checking *Send report via e-mail* and

@ezr-ondrej
Copy link
Member Author

I am trying to avoid the generation as it is misleading, see https://www.merriam-webster.com/dictionary/generation where it stated that first association is with

a body of living beings constituting a single step in the line of descent from an ancestor
what we do not want to state.

Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ezr-ondrej !

@tbrisker tbrisker merged commit 8b2ed6d into theforeman:gh-pages Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants