Add 1.8 headline features #355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ##### Provisioning interface support | ||
|
|
||
| Traditionally, Foreman stored the primary interface and additional interfaces separately. Foreman 1.8 now stores a single list of network interfaces for each host, one of which can be marked as the primary interface for the purposes of determining the FQDN and primary IP address. |
There was a problem hiding this comment.
maybe: one of which must be marked as the primary interface
|
except one nit, 👍 for the networking part |
|
@domcleal 👍 from my side (apart from the can/must) |
|
Thanks for the review, merged as d744ac0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ares or @tstrachota, would you mind giving this a quick read to ensure I've described the networking changes fairly?
If there's anything you think I should highlight, but haven't, please let me know. The full list of changes is in the main release notes section below.