Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify python2 for dockerfiles for v1 actions #69

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Conversation

minkimcello
Copy link
Contributor

@minkimcello minkimcello commented Nov 24, 2021

Motivation

https://github.com/thefrontside/interactors/actions/workflows/release.yml

Approach

  • Deleted the v1 tag (we should be using v# for branches and v#.# for tags but I didn't know any better at the time) and pushed v1.8 (latest) to the v1 branch. Now if anything breaks, I can create fixes and create PRs against the new v1 branch.
  • Updated the two dockerfiles that were installing python to install python2 instead.
  • Built the two images locally successfully.

TODOs

  • Update interactors #152 to try out the updated dockerfiles directly from this branch
  • Once ☝️ works, we can merge this PR and do a manual release of v1.9 and then update all of our frontside projects that are using the old release action to use v1.9

Copy link
Member

@cowboyd cowboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants