Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track failed publish attempts for preview action #70

Merged
merged 7 commits into from
Apr 29, 2022
Merged

Conversation

minkimcello
Copy link
Contributor

@minkimcello minkimcello commented Dec 14, 2021

The preview action attempts to publish preview packages three times.

This is all after it passes a long list of prerequisites and conditions. But the reason we attempt three times is in anticipation of any delays of npm updating its registry (in case someone pushes multiple commits in a short time span and publishing happens too quickly back to back).

Although unlikely, we should still keep track of packages that failed to publish even after the three attempts and include it in the github comment.

@frontsidejack
Copy link
Member

frontsidejack commented Dec 14, 2021

📣 NOTIFICATION
You are receiving this message because we did not publish any packages.

Generated by @thefrontside/actions Frontside

This was referenced Apr 29, 2022
@minkimcello minkimcello changed the title [WIP] Track failed publish attempts for preview action Track failed publish attempts for preview action Apr 29, 2022
@minkimcello minkimcello requested a review from taras April 29, 2022 14:35
Copy link
Member

@taras taras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from mk/release to v2 April 29, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants