Add "module" index for systems that can consume ES modules. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The @bigtest/mocha JavaScript sources are written using ES modules, but not every system that will be consuming @bigtest/mocha understands them. For those systems (specifically Node runtimes), we build an AMD equivalent using rollup.js and put the index for it in `dist/index.js`. On the other hand, if your system understands modules (like a webpack or a broccoli build) then you want to skip the intermediary build and just use the native sources directly. We can tell systems where the ES module representing the entry point is, by using the "module" property and pointing it to the primary module for our library.
cowboyd
added a commit
that referenced
this pull request
Jan 9, 2018
This was referenced Jan 9, 2018
cowboyd
pushed a commit
that referenced
this pull request
Feb 20, 2020
Add some really basic code for websocket connection from agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The @bigtest/mocha JavaScript sources are written using ES modules, but not every system that will be consuming @bigtest/mocha understands them. For those systems (specifically Node runtimes), we build an AMD equivalent using rollup.js and put the index for it in
dist/index.js. On the other hand, if your system understands modules (like a webpack or a broccoli build) then you want to skip the intermediary build and just use the native sources directly.We can tell systems where the ES module representing the entry point is, by using the "module" property and pointing it to the primary module for our library.