Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove convergence and interactor from monorepo #238

Merged
merged 2 commits into from
Apr 20, 2020

Conversation

minkimcello
Copy link
Contributor

Motivation

Just following orders. 👮

Interactor and convergence packages are outdated and no longer being used so we're removing them for tidying up purposes.

Approach

Removed interactor and convergence from the packages directory and updated test + release workflows.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2020

📣 NOTIFICATION

You are receiving this message because we did not publish any packages.

Generated by 🚫 dangerJS against ad5c205

Copy link
Member

@cowboyd cowboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green fields! 🧑‍🌾

@taras
Copy link
Member

taras commented Apr 18, 2020

@cowboyd should we add a mechanism to release action to somehow deprecate packages?

@cowboyd
Copy link
Member

cowboyd commented Apr 18, 2020

@cowboyd should we add a mechanism to release action to somehow deprecate packages?

That would actually be awesome.... how do you deprecate an NPM package?

@taras
Copy link
Member

taras commented Apr 18, 2020

@cowboyd
Copy link
Member

cowboyd commented Apr 19, 2020

Right. In that case, what about adding a deprecated flag to the package.json and then we have our action synchronize the deprecation state with.

@minkimcello
Copy link
Contributor Author

minkimcello commented Apr 20, 2020

@cowboyd @taras Moved discussion to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants