convert Subscription
from bare operation to iterator.
#696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to simplify working with streams and subscriptions, we need to be able to disambiguate them easily. The relationship between
Stream
andSubscription
is the same as that betweenIterable
->Iterator
andAsyncIterable
->AsyncIterator
.Approach
This converts
Subscription
into an API that is highly analogous toAsyncIterator
. Thenext()
method returns anOperation
which yields anIteratorResult
So in the same wayAsyncIterator
has:The
Subscription
api will look like:Once we have this in place, it is trivial to create a stream out of any Subscription:
We may decide later to rename
Stream
andSubscription
to something else that re-enforces this analogy further. However, we haven't been able to settle on anything that obviously clicks, so we'll defer that for now, and instead focus on the API.