Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch gcp auth to updated actions #189

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Conversation

jbolda
Copy link
Contributor

@jbolda jbolda commented Jan 6, 2023

Motivation

The last deploy on the main branch failed. Fix so we can deploy again.

W0103 20:08:25.644046    [30](https://github.com/thefrontside/playhouse/actions/runs/3832572592/jobs/6523039621#step:12:31)38 gcp.go:119] WARNING: the gcp auth plugin is deprecated in v1.22+, unavailable in v1.26+; use gcloud instead.
To learn more, consult https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke
Error: UPGRADE FAILED: execution error at (backstage-mincharts/templates/secrets.yaml:15:33): You must provide a Auth Session Client Secret

Approach

Rather than using the gcloud calls, I switch to use the action. I suspect this will require less effort on our end to maintain.

Alternate Designs

Use the plugin in which the error suggests.

Possible Drawbacks or Risks

Hard to test this without hitting the merge button.

@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2023

⚠️ No Changeset found

Latest commit: d8bb675

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@frontsidejack
Copy link
Member

frontsidejack commented Jan 6, 2023

📣 NOTIFICATION
You are receiving this message because we did not publish any packages.

Generated by @thefrontside/actions Frontside

@jbolda jbolda merged commit cd572a8 into main Jan 6, 2023
@jbolda jbolda deleted the gcp-auth-plugin-deprecated branch January 6, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants