Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SimpleBLE to 0.7.3 base #193

Closed
wants to merge 1 commit into from

Conversation

Apollon77
Copy link
Contributor

@Apollon77 Apollon77 commented Apr 22, 2024

This fixes the macos functionality. testd by getting hw adapter (see #189) and also device scanning

I chose OpenBluetoothToolbox/SimpleBLE@646bf48 which is the 0.7.3 release commit

fixes #191

@thegecko
Copy link
Owner

thegecko commented Apr 22, 2024

Did you try running the test suite?

AFAIK we can't upgrade beyond v0.6.1 due to this: OpenBluetoothToolbox/SimpleBLE#277

@Apollon77
Copy link
Contributor Author

which test suite you mean? Tell me and I do.

I just tried getting adapters and scanning for devices which was completely "not working" on macos in the 0.6 range before.

But Ok if more is broken then meehhh ...

@Apollon77
Copy link
Contributor Author

PS: If you mean the test suite for webbluetooth ... then no ... run now and yes red ... :-( I try now

@Apollon77
Copy link
Contributor Author

PS: test suite also fails on my macos with 0.6.1 ... soooo ... I was expecting to see what githib says :-) Thenlet me close the PR for now ...

@Apollon77 Apollon77 closed this Apr 22, 2024
@thegecko
Copy link
Owner

You may need to set up a device to run the tests https://github.com/thegecko/webbluetooth?tab=readme-ov-file#testing

@Apollon77
Copy link
Contributor Author

Yes I just realized this ... so I need to purchase a microbit device ... ;-)

Thank you for your patience with me :-) Was not that cklear wheile checking the readme

@Apollon77
Copy link
Contributor Author

microbit device ordered ... will test as soon as it has arrived

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS do not work
2 participants