fix: remove table formatting from github gists #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoxys
requested changes
May 22, 2022
src/sass/_markdown.scss
Outdated
| width: 100%; | ||
| text-align: left; | ||
| .table-wrap { | ||
| table:not(.lntable) { |
There was a problem hiding this comment.
I would like to do the opposite and use table:not(.lntable):not(.gist .highlight).
xoxys
changed the title
|
Fixed CI and added a Gist usage example. Thanks again! |
xoxys
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
gistshortcode to include a code block into the site, the css code generated from the_markdown.scsswill cause the gist to include extra padding and bottom borders due to how thetablecss is laid out.This is the problematic line..
It seems that there's already a structure in place to solve this issue, as there's already a utility method that wraps all written
<table>tags in<div="table-wrap">tags. So this PR moved the scss to only target those tables.This results in the correct look: