Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy img #70

Closed
wants to merge 3 commits into from
Closed

Lazy img #70

wants to merge 3 commits into from

Conversation

i7d3v3l0p3r
Copy link
Contributor

Made lazy loaded img shortcode that will help to improve performance of page traffic.

@thegeeklab-bot
Copy link

thegeeklab-bot commented Feb 19, 2021 •
edited

LHCI Report Overview

Report URL Performance Accessibility Best-Practices SEO PWA
Link http://localhost:36561/ 79 % 100 % 100 % 96 % 25 %
Link http://localhost:36561/404.html 80 % 100 % 100 % 100 % 25 %
Link http://localhost:36561/posts/ 79 % 100 % 100 % 100 % 25 %

@i7d3v3l0p3r
Copy link
Contributor Author

@xoxys I would be grateful if you could help correct linguistic errors

@xoxys
Copy link
Member

xoxys commented Feb 20, 2021

@i7d3v3l0p3r Thanks for your work! We use already a custom img shortcode in another theme https://github.com/thegeeklab/hugo-geekblog/blob/master/layouts/shortcodes/img.html

I would like to transfer this shortcode to hugo-geekdoc and extend it with an optional loading="lazy". Are you ok with this approach?

@xoxys xoxys mentioned this pull request Feb 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@i7d3v3l0p3r @thegeeklab-bot @xoxys