Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize cover images #34

Open
geealbers opened this issue Apr 24, 2020 · 0 comments
Open

Optimize cover images #34

geealbers opened this issue Apr 24, 2020 · 0 comments
Assignees

Comments

@geealbers
Copy link
Member

As suggested by @mandrijauskas in PR #31, the size of the cover images are okay but there may be some room for improvement. Using srcset especially for mobile seems worth doing prior to launch.

From what I'm seeing in the lighthouse test it's at 54 performance which isn't too bad. The only thing that might improve it would be to use smaller image sizes with srcsets for those resolutions, as well as using more compressed formats (webp, jpeg xr, etc) but that's getting nitty gritty performance heavy.

One of the volume authors also asked that we try to show more of the portrait when in the horizontal desktop browser configuration, so looking at varying image sizes might help there as well.

@geealbers geealbers self-assigned this Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant