Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quire build breaks if no cover image is specified #844

Open
1 task done
geealbers opened this issue Sep 12, 2023 · 3 comments
Open
1 task done

Quire build breaks if no cover image is specified #844

geealbers opened this issue Sep 12, 2023 · 3 comments
Assignees
Labels
enhancement Proposed new feature. There are no guarantees a suggested enhancement will be included in Quire. quire-11ty This is an issue with the quire-11ty package status:backlog Issue is a lower priority but needs to eventually be addressed

Comments

@geealbers
Copy link
Member

Before proceeding, make sure there isn’t an existing issue for this bug.

  • I have searched the existing issues and determined this is a new bug.

Expected Behavior

I should be able to remove the image from the index.md cover file, and have the cover display with the color background and title typography alone.

Actual Behavior

Instead, when there is not image specified. And error is thrown on quire build which stops the build as imcomplete.

[vite:build-html] EISDIR: illegal operation on a directory, read
file: /Users/galbers/test-cover-image/.11ty-vite/index.html
[11ty] Encountered a Vite build error, restoring original Eleventy output to _site [Error: EISDIR: illegal operation on a directory, read] {
  errno: -21,
  code: 'PLUGIN_ERROR',
  syscall: 'read',
  pluginCode: 'EISDIR',
  plugin: 'vite:build-html',
  hook: 'transform',
  id: '/Users/galbers/test-cover-image/.11ty-vite/index.html',
  watchFiles: [
    '/Users/galbers/test-cover-image/.11ty-vite/contents/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/catalogue/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/about/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/contributors/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/bibliography/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/intro/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/catalogue/1/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/catalogue/2/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/essay/index.html',
    '\x00vite/modulepreload-polyfill',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/javascript/lightbox/index.js',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/javascript/modal/index.js',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/javascript/application/index.js',
    '/Users/galbers/test-cover-image/package.json',
    '/Users/galbers/test-cover-image/node_modules/lit/index.js',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/fonts/index.scss',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/styles/application.scss',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/styles/screen.scss',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/styles/custom.css',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/javascript/application/canvas-panel.js',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/javascript/application/soundcloud-api.min.js',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/javascript/application/accordion.js',
    '/Users/galbers/test-cover-image/_plugins/search/search.js',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/javascript/application/scroll-to-hash.js',
    '/Users/galbers/test-cover-image/node_modules/lit-html/directives/unsafe-html.js'
  ]
}
[11ty] Problem writing Eleventy templates: (more in DEBUG output)
[11ty] ENOTEMPTY: directory not empty, rename '/Users/galbers/test-cover-image/.11ty-vite' -> '_site' (via Error)
[11ty] 
[11ty] Original error stack trace: Error: ENOTEMPTY: directory not empty, rename '/Users/galbers/test-cover-image/.11ty-vite' -> '_site'
[11ty] Copied 2488 files / Wrote 10 files in 10.29 seconds (1029.0ms each, v2.0.1)

Steps to Reproduce

  1. Start a new project
  2. Delete the image: entry from content/index.md
  3. Run quire build

Version Numbers

[test-cover-image]
quire-cli 1.0.0-rc.10
quire-11ty 1.0.0-rc.14
starter https://github.com/thegetty/quire-starter-default@2.6.0

[System]
quire-cli 1.0.0-rc.10
node v18.16.0
npm 9.5.1
os Darwin 22.3.0

Web Browser

No response

Relevant Terminal/Shell Output

No response

Supporting Information

No response

@geealbers geealbers added the status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues. label Sep 12, 2023
@Erin-Cecele Erin-Cecele added status:selected for development Issue has been triaged and will be fixed quire-11ty This is an issue with the quire-11ty package bug Actual behavior does not match expected behavior status:backlog Issue is a lower priority but needs to eventually be addressed and removed status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues. status:selected for development Issue has been triaged and will be fixed labels Sep 21, 2023
@Erin-Cecele
Copy link
Collaborator

This issue is currently backlogged but will be addressed in time. In the meantime, the docs will be amended to warn users that build will break if the default cover images is deleted and left blank in the index.md file

@Erin-Cecele Erin-Cecele added the docs needed Issue is not a bug and additional documentation is necessary to communicate expected behavior label Sep 21, 2023
@Erin-Cecele
Copy link
Collaborator

Erin-Cecele commented Oct 11, 2023

Adding a note that this issue needs to be tested to pinpoint where exactly the break is occurring.

@Erin-Cecele
Copy link
Collaborator

Confirming the build will break when: image: value is left blank, when the image: value is "", and when image: is removed completely. The build will work if the image itself has been deleted but the path is still listed as a value (image: spiral-overlay.png)

@Erin-Cecele Erin-Cecele added enhancement Proposed new feature. There are no guarantees a suggested enhancement will be included in Quire. and removed bug Actual behavior does not match expected behavior docs needed Issue is not a bug and additional documentation is necessary to communicate expected behavior labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Proposed new feature. There are no guarantees a suggested enhancement will be included in Quire. quire-11ty This is an issue with the quire-11ty package status:backlog Issue is a lower priority but needs to eventually be addressed
Projects
None yet
Development

No branches or pull requests

2 participants