Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning re: cover image #708

Merged
merged 1 commit into from
Dec 1, 2023
Merged

add warning re: cover image #708

merged 1 commit into from
Dec 1, 2023

Conversation

Erin-Cecele
Copy link
Collaborator

Thank you for contributing to the Quire Documentation & Website! Please complete the form below to submit your pull request for review.

For the Title of this pull request, please use the format "Type/Issue-#: Brief description." For Type, the options are Edit, Add, Translate. Issue-# is only needed if this pull request addresses an existing issue.

Checklist

Please put an X within the brackets that apply [X].

  • I have read the CONTRIBUTING.md file.

  • I have made my changes in a new branch and not directly in the main branch

  • I am requesting feedback on a draft pull request

Is this pull request related to an open issue? If so, what is the issue number?

Yes, this is related to thegetty/quire#844.

Please describe the goal of this pull request and the changes that were made.

Add a warning telling people not to leave image blank on the cover or remove the image attribute from the page YAML of the cover.

Additional Comments

Copy link
Member

@geealbers geealbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a GitHub/Jira issue for this already? If not, can you write one up?

@Erin-Cecele
Copy link
Collaborator Author

Erin-Cecele commented Dec 1, 2023 via email

@Erin-Cecele Erin-Cecele merged commit 9275cc9 into main Dec 1, 2023
@Erin-Cecele Erin-Cecele deleted the edit/cover-images-844 branch December 1, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants